deps: require at least libc 0.2.160 #52
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mozilla#29 added the following `libc` import: ``` rust use libc::{ freeifaddrs, getifaddrs, getpid, if_data, if_indextoname, ifaddrs, in6_addr, in_addr, sockaddr_in, sockaddr_in6, sockaddr_storage, AF_UNSPEC, PF_ROUTE, RTAX_MAX, }; ``` `RTAX_MAX` was added in `libc` `0.2.160`: https://github.com/rust-lang/libc/releases/tag/0.2.160 More specifically rust-lang/libc#3714. This commit makes sure the above new requirement is encoded in the `mtu` `Cargo.toml` `libc` dependency declaration. See CI failure without discussed in mozilla#51 (comment).
mxinden
commented
Nov 29, 2024
Comment on lines
24
to
+25
| # Don't increase beyond what Firefox is currently using: https://searchfox.org/mozilla-central/source/Cargo.lock | ||
| libc = { version = "0.2", default-features = false } | ||
| libc = { version = "0.2.160", default-features = false } |
There was a problem hiding this comment.
These lines are at odds with each other, as mozilla-central currently depends on libc v0.2.158. We will need to bump mozilla-central's libc version before we can merge here.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
==========================================
- Coverage 93.61% 93.42% -0.20%
==========================================
Files 5 5
Lines 517 517
==========================================
- Hits 484 483 -1
- Misses 33 34 +1 ☔ View full report in Codecov by Sentry. |
|
This might change with the Solaris PR, which (as a side effect) pulls in more things from bindgen vs. libc. If we land that first, the libc version requirement might go away. |
|
Closing this in favor of #45, which addresses this as a side effect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#29 added the following
libcimport:RTAX_MAXwas added inlibc0.2.160:https://github.com/rust-lang/libc/releases/tag/0.2.160
More specifically rust-lang/libc#3714.
This commit makes sure the above new requirement is encoded in the
mtuCargo.tomllibcdependency declaration.See CI failure without discussed in #51 (comment).