Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include env var in validation error message #333

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion lib/convict.js
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,11 @@ function normalizeSchema(name, node, props, fullName, env, argv, sensitive) {
// attach the value and the property's fullName to the error
e.fullName = fullName;
e.value = x;

if (o.env) {
e.env = o.env;
}

throw e;
}
};
Expand Down Expand Up @@ -648,7 +653,13 @@ let convict = function convict(def, opts) {
let e = errors[i];

if (e.fullName) {
err_buf += e.fullName + ': ';
err_buf += e.fullName;

if (e.env) {
err_buf += '[' + e.env + ']';
}

err_buf += ': ';
}
if (e.message) err_buf += e.message;
if (e.value && !sensitive.has(e.fullName)) {
Expand Down
2 changes: 1 addition & 1 deletion test/cases/env_syntax.out
Original file line number Diff line number Diff line change
@@ -1 +1 @@
foo.bar: must be one of the possible values: ["a","b"]: value was "c"
foo.bar[BAR]: must be one of the possible values: ["a","b"]: value was "c"