Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Getter #342

Closed
wants to merge 26 commits into from
Closed

Custom Getter #342

wants to merge 26 commits into from

Commits on Dec 15, 2019

  1. [Remove dependencies] Convert some default format to external package (… 

    …#327)

Multi-packages split
    @A-312 @madarche
    A-312 authored and madarche committed Dec 15, 2019
    Configuration menu
    Copy the full SHA
    19e7f9f View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG

    @madarche
    madarche committed Dec 15, 2019
    Configuration menu
    Copy the full SHA
    9066f56 View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2019

  1. Regenerating package-lock.json 

    with current NPM registry state
    @madarche
    madarche committed Dec 28, 2019
    Configuration menu
    Copy the full SHA
    30bcc2e View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2020

  1. Update Precendence order according implementation 

    Fixes #211 and #208
    @zaverden
    zaverden committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    4d3988d View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2020

  1. [Remove dependencies] Convert some default format to external package (… 

    …#327)

Multi-packages split
    @A-312
    A-312 committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    f8f9b24 View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG

    @madarche @A-312
    madarche authored and A-312 committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    50f2936 View commit details
    Browse the repository at this point in the history

  3. Regenerating package-lock.json 

    with current NPM registry state
    @madarche @A-312
    madarche authored and A-312 committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    a91ebe6 View commit details
    Browse the repository at this point in the history

  4. Merge #314: Update Precendence order documentation according implemen… 

    …tation
    @zaverden @A-312
    zaverden authored and A-312 committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    1b850a6 View commit details
    Browse the repository at this point in the history

  5. Merge #336: Fire error with 'properties' keyname in schema and 'prope… 

    …rties' of convict become '_cvtProperties'
    @A-312
    A-312 committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    cbb0f52 View commit details
    Browse the repository at this point in the history

  6. Merge #348: Add doc about second argument of convict

    @A-312
    A-312 committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    374f97b View commit details
    Browse the repository at this point in the history

  7. Merge #347: Use Chai for test cases

    @A-312
    A-312 committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    4ea2369 View commit details
    Browse the repository at this point in the history

  8. Merge #352: Coerce from strings to their proper types (NOT MORE) + co… 

    …de review on coercing
    @A-312
    A-312 committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    23d3a85 View commit details
    Browse the repository at this point in the history

  9. Force the default SwitchCase value 

    https://eslint.org/docs/rules/indent#switchcase
    @A-312
    A-312 committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    4edb3d9 View commit details
    Browse the repository at this point in the history

  10. codereview: transform coerce method to be call only once (in normaliz… 

    …eSchema)
    @A-312
    A-312 committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    993e7de View commit details
    Browse the repository at this point in the history

  11. code review: let should only be used when needed

    @A-312
    A-312 committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    d0dcf98 View commit details
    Browse the repository at this point in the history

  12. code review: Better error handler 

    + normalize simple and double quotes
    @A-312
    A-312 committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    413b662 View commit details
    Browse the repository at this point in the history

  13. All test files should use a new independant instance of convict

    @A-312
    A-312 committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    76d49f9 View commit details
    Browse the repository at this point in the history

  14. Add AddCustomGetter

    @A-312
    A-312 committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    5a89dd8 View commit details
    Browse the repository at this point in the history

  15. Add rewrite argument to addFormat (standardize with addGetter) 

    Fire error when we try to rewrite an existing Format (rewrite = true to rewrite an existing Format).
    @A-312
    A-312 committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    e28c9a1 View commit details
    Browse the repository at this point in the history

  16. Implementation of custom getter

    @A-312
    A-312 committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    2deb091 View commit details
    Browse the repository at this point in the history

  17. Rename overlay() to applyValues() because is more accurate, `appl… 

    …yValues()` name is similar that `applyGetters()`, is more understandable
    @A-312
    A-312 committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    3a2e6b1 View commit details
    Browse the repository at this point in the history

  18. Add getOrigin and Improve tests

    @A-312
    A-312 committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    aacfe0d View commit details
    Browse the repository at this point in the history

  19. add sortGetters(), getGettersOrder(), refreshGetters() & INCORRECT_US… 

    …AGE error
    @A-312
    A-312 committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    01da601 View commit details
    Browse the repository at this point in the history

  20. Modify set for priority support & add tests

    @A-312
    A-312 committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    6ba914f View commit details
    Browse the repository at this point in the history

  21. Fix applyGetter when re-run: Check the current level before apply a g… 

    …etter and add tests
    @A-312
    A-312 committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    c389e16 View commit details
    Browse the repository at this point in the history

  22. Add documentation about custom getter

    @A-312
    A-312 committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    3ad8b5f View commit details
    Browse the repository at this point in the history