Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logic to track rendering area of various PDF ops #19043

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Add logic to track rendering area of various PDF ops #19043

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
54be55a
Add logic to track rendering area of various PDF ops
nicolo-ribaudo Nov 14, 2024
5a6a877
Hook up the ops bbox logic to the pdf debugger
nicolo-ribaudo Nov 14, 2024
00b6012
fixup! Add logic to track rendering area of various PDF ops
nicolo-ribaudo Nov 18, 2024
b689701
fixup! Add logic to track rendering area of various PDF ops
nicolo-ribaudo Nov 18, 2024
395be2b
fixup! Hook up the ops bbox logic to the pdf debugger
nicolo-ribaudo Nov 18, 2024
49c4689
fixup! Add logic to track rendering area of various PDF ops
nicolo-ribaudo Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/display/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ import {
NodeStandardFontDataFactory,
} from "display-node_utils";
import { CanvasGraphics } from "./canvas.js";
import { CanvasRecorder } from "./canvas_recorder.js";
import { DOMCanvasFactory } from "./canvas_factory.js";
import { DOMCMapReaderFactory } from "display-cmap_reader_factory";
import { DOMFilterFactory } from "./filter_factory.js";
Expand Down Expand Up @@ -1517,9 +1518,22 @@ class PDFPageProxy {
this._pumpOperatorList(intentArgs);
}

const recordingContext =
this._pdfBug &&
globalThis.StepperManager?.enabled &&
!this._recordedGroups
? new CanvasRecorder(canvasContext)
: null;

const complete = error => {
intentState.renderTasks.delete(internalRenderTask);

if (recordingContext) {
this._recordedGroups =
CanvasRecorder.getFinishedGroups(recordingContext);
internalRenderTask.stepper.setOperatorGroups(this._recordedGroups);
}

// Attempt to reduce memory usage during *printing*, by always running
// cleanup immediately once rendering has finished.
if (this._maybeCleanupAfterRender || intentPrint) {
Expand Down Expand Up @@ -1552,7 +1566,7 @@ class PDFPageProxy {
callback: complete,
// Only include the required properties, and *not* the entire object.
params: {
canvasContext,
canvasContext: recordingContext ?? canvasContext,
viewport,
transform,
background,
Expand Down
Loading