Remove the basic Math.sumPrecise polyfill#20958
Draft
Snuffleupagus wants to merge 1 commit intomozilla:masterfrom
Draft
Remove the basic Math.sumPrecise polyfill#20958Snuffleupagus wants to merge 1 commit intomozilla:masterfrom
Math.sumPrecise polyfill#20958Snuffleupagus wants to merge 1 commit intomozilla:masterfrom
Conversation
This is already polyfilled properly via core-js in `legacy` builds, and the only reason that it wasn't already removed is that the tests (on the bots) use the "modern" builds and Chrome didn't support `Math.sumPrecise` until now; see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Math/sumPrecise#browser_compatibility
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #20958 +/- ##
=======================================
Coverage 62.51% 62.51%
=======================================
Files 172 172
Lines 121789 121776 -13
=======================================
- Hits 76134 76132 -2
+ Misses 45655 45644 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is already polyfilled properly via core-js in
legacybuilds, and the only reason that it wasn't already removed is that the tests (on the bots) use the "modern" builds and Chrome didn't supportMath.sumPreciseuntil now; see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Math/sumPrecise#browser_compatibility