Skip to content

Remove the basic Math.sumPrecise polyfill#20958

Draft
Snuffleupagus wants to merge 1 commit intomozilla:masterfrom
Snuffleupagus:rm-sumPrecise-polyfill
Draft

Remove the basic Math.sumPrecise polyfill#20958
Snuffleupagus wants to merge 1 commit intomozilla:masterfrom
Snuffleupagus:rm-sumPrecise-polyfill

Conversation

@Snuffleupagus
Copy link
Collaborator

This is already polyfilled properly via core-js in legacy builds, and the only reason that it wasn't already removed is that the tests (on the bots) use the "modern" builds and Chrome didn't support Math.sumPrecise until now; see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Math/sumPrecise#browser_compatibility

This is already polyfilled properly via core-js in `legacy` builds, and the only reason that it wasn't already removed is that the tests (on the bots) use the "modern" builds and Chrome didn't support `Math.sumPrecise` until now; see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Math/sumPrecise#browser_compatibility
@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.51%. Comparing base (2643125) to head (8ac7305).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #20958   +/-   ##
=======================================
  Coverage   62.51%   62.51%           
=======================================
  Files         172      172           
  Lines      121789   121776   -13     
=======================================
- Hits        76134    76132    -2     
+ Misses      45655    45644   -11     
Flag Coverage Δ
fonttest 7.65% <ø> (?)
unittestcli 62.49% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants