Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add banner for project managers, give priority to roles within locale #3422

Merged
merged 16 commits into from
Nov 5, 2024
Merged

Add banner for project managers, give priority to roles within locale #3422

merged 16 commits into from
Nov 5, 2024

Commits on Nov 4, 2024

  1. Add banner for project managers, given priority to role within locale 

    This adds a banner for users defined as "Project Manager" within a project.
To reduce the space for confusion, I changed the tooltip of MNGR from "Manager" to "Team Manager".

This also makes the priority of roles consistent between front-end and back-end:
- If a user as a role within the locale (translator, manager), we use that for the banner.
- If a user is set as PM, we use that even if the user is an Admin.

Finally, this adds CSS variables for users, instead of reusing the ones for translation status.
    @flodolo @mathjazz
    flodolo authored and mathjazz committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    c544d11 View commit details
    Browse the repository at this point in the history

  2. Ignore system users for banners

    @flodolo @mathjazz
    flodolo authored and mathjazz committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    ac3958d View commit details
    Browse the repository at this point in the history

  3. Address comments (partial)

    @flodolo @mathjazz
    flodolo authored and mathjazz committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    3a81869 View commit details
    Browse the repository at this point in the history

  4. Fix JSON error

    @flodolo @mathjazz
    flodolo authored and mathjazz committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    85766ef View commit details
    Browse the repository at this point in the history

  5. Determine the PM status more efficiently

    @mathjazz
    mathjazz committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    5180b8c View commit details
    Browse the repository at this point in the history

  6. Using values_list() is generally better than list comprehensions for … 

    …retrieving specific fields from a queryset
    @mathjazz
    mathjazz committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    cc6d287 View commit details
    Browse the repository at this point in the history

  7. ruff

    @mathjazz
    mathjazz committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    ef2f5c1 View commit details
    Browse the repository at this point in the history

  8. Use status identifier as a class name

    @mathjazz
    mathjazz committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    0a90835 View commit details
    Browse the repository at this point in the history

  9. The term role is already taken, let's settle for status consistently

    @mathjazz
    mathjazz committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    c68441e View commit details
    Browse the repository at this point in the history

  10. CSS class names are case sensitive

    @mathjazz
    mathjazz committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    da0c8ec View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. The isAdmin flag is true if the user is a superuser, not PM

    @mathjazz
    mathjazz committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    dcb4eee View commit details
    Browse the repository at this point in the history

  2. Introduce isPM flag and use it where isAdmin was used before

    @mathjazz
    mathjazz committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    8293bda View commit details
    Browse the repository at this point in the history

  3. Rename: managerForLocales -> canManageLocale, translatorForLocales ->… 

    … canTranslateLocales
    @mathjazz
    mathjazz committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    947a6e9 View commit details
    Browse the repository at this point in the history

  4. Introduce managerForLocales and translatorForLocales and use it in Us… 

    …erStatus instead of canManageLocales and canTranslateLocales
    @mathjazz
    mathjazz committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    acffd9a View commit details
    Browse the repository at this point in the history

  5. Fix ruff

    @mathjazz
    mathjazz committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    9d26022 View commit details
    Browse the repository at this point in the history

  6. Add Project Manager Status Icon to the spec

    @mathjazz
    mathjazz committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    203c116 View commit details
    Browse the repository at this point in the history