Configurable core count #2363
Draft
Configurable core count #2363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems to be a bad deal: increases line count and obscures the origin of values in a pretty long function.
Problems:
- Will now show "extended" core count in scheduler instead of
"true" core count
- OTOH will not show more jobs than cores anymore, which
was weird
- Job distribution still kinda sucks; what about
- "full core" vs "SMT core" differences? (The second half of
cores on a 2-way SMT CPU is usually only 10%-30% as fast as the
first half)
- Other effects, such as memory bandwith and thermal throttling,
that make a core faster on a lightly loaded machine (though,
seems to be typically a small effect of 10%..30% for compiler-
type work)
- CPU performance differences?
- Ugh, would need a suitable benchmark load and some heuristics
to get a usable result on a not-necessarily-unloaded machine
- Automatic memory limiting? When running out of memory, stop
all jobs except one and let them finish sequentially.
- Any other ideas?
- Maybe reduce job count temporarily as well? But when to lift
the reduction then? It's all pretty messy!
- Maybe kill the most memory-intensive job and send it to
another machine, or the same machine after other jobs have
all finished?
- Actually! To guarantee progress, it's probably best to
kill the youngest jobs first
- But what if the youngest job is the one using the most
memory...?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2363 +/- ##
===========================================
+ Coverage 30.91% 67.51% +36.60%
===========================================
Files 53 65 +12
Lines 20112 35460 +15348
Branches 9755 0 -9755
===========================================
+ Hits 6217 23940 +17723
- Misses 7922 11520 +3598
+ Partials 5973 0 -5973 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sylvestre
reviewed
Mar 14, 2025
| @@ -430,6 +431,7 @@ impl DistSystem { | |||
| Some(SocketAddr::from(([0, 0, 0, 0], server_addr.port()))), | |||
| self.scheduler_url().to_url(), | |||
| token, | |||
| 4, | |||
There was a problem hiding this comment.
it would be great if the test could verify that, indeed, 4 core are being used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some nodes can run out of memory if all of their cores are used. There may be other reasons to limit the amount of cores used.