-
Notifications
You must be signed in to change notification settings - Fork 623
make sccache -s always return current cache size #2419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
4740041 to
9ded41b
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2419 +/- ##
=======================================
Coverage 71.18% 71.18%
=======================================
Files 64 65 +1
Lines 35592 35603 +11
=======================================
+ Hits 25335 25343 +8
- Misses 10257 10260 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d0894e8 to
340c5d6
Compare
93868cb to
dc7243d
Compare
|
Hello, do you need me to do something on this PR ? |
I think this name makes more sense, given that this type holds a lazily initialized LRU cache
sccache server disk cache is usually initiated by the first compilation request. If `sccache -s` is issued before then, sccache will not return the currently occupied cache size This PR fixes that
2b2ba7c to
41e34bd
Compare
Merging this PR will not alter performance
Comparing Footnotes
|
|
@sylvestre Hello ! I keep seeing pushes made to this PR. Do you need me to do something on it, or are you just testing it ? |
|
I was just running the benchmarks again |
|
Ok ! Lmk if anything prevents this from being merged |
sccache server disk cache is usually initiated by the first compilation request. If
sccache -sis issued before then, sccache will not return the currently occupied cache size. This PR fixes that by querying the underlying LruDiskCache incurrent_size(). I don't think there are performance implications of this, but I am not sure.I also renamed LazyDiskCache to LazyLruDiskCache, because I think the name is more clear. Let me know if you want me to revert that change