Skip to content

Conversation

@iTrooz
Copy link
Contributor

@iTrooz iTrooz commented Jul 2, 2025

sccache server disk cache is usually initiated by the first compilation request. If sccache -s is issued before then, sccache will not return the currently occupied cache size. This PR fixes that by querying the underlying LruDiskCache in current_size(). I don't think there are performance implications of this, but I am not sure.

I also renamed LazyDiskCache to LazyLruDiskCache, because I think the name is more clear. Let me know if you want me to revert that change

@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2025

Codecov Report

❌ Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.18%. Comparing base (3fe258a) to head (b71fe2c).

Files with missing lines Patch % Lines
src/cache/disk.rs 83.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2419   +/-   ##
=======================================
  Coverage   71.18%   71.18%           
=======================================
  Files          64       65    +1     
  Lines       35592    35603   +11     
=======================================
+ Hits        25335    25343    +8     
- Misses      10257    10260    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sylvestre sylvestre force-pushed the always_show_cache branch 3 times, most recently from 93868cb to dc7243d Compare September 25, 2025 06:34
@iTrooz
Copy link
Contributor Author

iTrooz commented Sep 25, 2025

Hello, do you need me to do something on this PR ?

I think this name makes more sense, given that this type holds a lazily initialized LRU cache
sccache server disk cache is usually initiated by the first compilation request. If `sccache -s` is issued before then, sccache will not return the currently occupied cache size

This PR fixes that
@mozilla mozilla deleted a comment from codspeed-hq bot Jan 10, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 10, 2026

Merging this PR will not alter performance

✅ 27 untouched benchmarks
⏩ 2 skipped benchmarks1


Comparing iTrooz:always_show_cache (b71fe2c) with main (3fe258a)

Open in CodSpeed

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@iTrooz
Copy link
Contributor Author

iTrooz commented Jan 12, 2026

@sylvestre Hello ! I keep seeing pushes made to this PR. Do you need me to do something on it, or are you just testing it ?

@sylvestre
Copy link
Collaborator

I was just running the benchmarks again

@iTrooz
Copy link
Contributor Author

iTrooz commented Jan 12, 2026

Ok ! Lmk if anything prevents this from being merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants