Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(OPST-1385): renaming google workgroups module to mozilla workgroup #234

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Basma1912
Copy link
Contributor

No description provided.

@Basma1912 Basma1912 changed the title renaming google workgroups module to mozilla workgroup chore(OPST-1385): renaming google workgroups module to mozilla workgroup Nov 6, 2024
@Basma1912 Basma1912 marked this pull request as ready for review November 6, 2024 17:33
Copy link
Member

@bkochendorfer bkochendorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably no need to keep the old one around as mozilla_workgroup_old, nothing should call that right?

@Basma1912
Copy link
Contributor Author

Basma1912 commented Nov 6, 2024

that is correct -- I just deleted it

Signed-off-by: Basma1912 <[email protected]>
## Example
```hcl
module "workgroup" {
source = "github.com/mozilla/terraform-modules//google_workgroup?ref=main"
Copy link
Member

@jasonthomas jasonthomas Nov 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
source = "github.com/mozilla/terraform-modules//google_workgroup?ref=main"
source = "github.com/mozilla/terraform-modules//mozilla_workgroup?ref=main"

This should be mozilla_workgroup reference, but this is pulled in from the example1.tf, so that needs to be updated first and then the doc regenerated.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this was updated on the README directly, but this actually pulled in from the example via terraform-docs command using this reference https://github.com/mozilla/terraform-modules/blob/d8c958ff41991450d897ca6cd40ab25fdda87bb5/mozilla_workgroup/.terraform-docs.yml .

We should update https://github.com/mozilla/terraform-modules/blob/d8c958ff41991450d897ca6cd40ab25fdda87bb5/mozilla_workgroup/examples/example1.tf.

Once example1.tf is updated, run terraform-docs to generate the README document.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I accepted the changes on the README .. I will update the example1.tf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants