-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(OPST-1385): renaming google workgroups module to mozilla workgroup #234
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Basma1912 <[email protected]>
Signed-off-by: Basma1912 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably no need to keep the old one around as mozilla_workgroup_old
, nothing should call that right?
that is correct -- I just deleted it |
Signed-off-by: Basma1912 <[email protected]>
mozilla_workgroup/README.md
Outdated
## Example | ||
```hcl | ||
module "workgroup" { | ||
source = "github.com/mozilla/terraform-modules//google_workgroup?ref=main" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
source = "github.com/mozilla/terraform-modules//google_workgroup?ref=main" | |
source = "github.com/mozilla/terraform-modules//mozilla_workgroup?ref=main" |
This should be mozilla_workgroup reference, but this is pulled in from the example1.tf, so that needs to be updated first and then the doc regenerated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this was updated on the README directly, but this actually pulled in from the example via terraform-docs command using this reference https://github.com/mozilla/terraform-modules/blob/d8c958ff41991450d897ca6cd40ab25fdda87bb5/mozilla_workgroup/.terraform-docs.yml .
We should update https://github.com/mozilla/terraform-modules/blob/d8c958ff41991450d897ca6cd40ab25fdda87bb5/mozilla_workgroup/examples/example1.tf.
Once example1.tf is updated, run terraform-docs
to generate the README document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh I accepted the changes on the README .. I will update the example1.tf
Co-authored-by: Jason Thomas <[email protected]>
Co-authored-by: Jason Thomas <[email protected]>
Signed-off-by: Basma1912 <[email protected]>
Signed-off-by: Basma1912 <[email protected]>
No description provided.