Skip to content
This repository was archived by the owner on Dec 16, 2022. It is now read-only.

Switching default OneCRL pin to 'stable' tag #127

Merged
merged 1 commit into from
Nov 28, 2017
Merged

Switching default OneCRL pin to 'stable' tag #127

merged 1 commit into from
Nov 28, 2017

Conversation

cr
Copy link
Contributor

@cr cr commented Aug 9, 2017

This resolves #62.

@cr cr added this to the v3.1.2 milestone Aug 9, 2017
@cr cr self-assigned this Aug 9, 2017
@cr cr requested a review from mwobensmith August 9, 2017 13:37
@cr
Copy link
Contributor Author

cr commented Aug 9, 2017

Mind that #123 is breaking our tests, too. We have to test locally with s/nsILocalFile/nsIFile in scan_worker.js or land in the blind.

@cr cr mentioned this pull request Aug 9, 2017
Merged
@cr cr force-pushed the issue62_onecrltag branch from 70ad18d to 6a653c6 Compare August 9, 2017 16:41
@cr
Copy link
Contributor Author

cr commented Aug 9, 2017

Rebased on top of #125. Tests should be passing now.

@cr
Copy link
Contributor Author

cr commented Aug 9, 2017

Now that's brilliant. The OneCRL "stable" version bails out with an error:

2017-08-09 17:03:09 INFO MainThread tlscanary.modes.basemode Updating OneCRL revocation data
# github.com/mozmark/OneCRL-Tools/oneCRL2RevocationsTxt
../../.tlscanary/go/src/github.com/mozmark/OneCRL-Tools/oneCRL2RevocationsTxt/main.go:51: multiple-value config.GetRecordURL() in single-value context

@cr
Copy link
Contributor Author

cr commented Aug 9, 2017

I have filed mozmark/OneCRL-Tools/issues/40. There is no immediate pressure, but actually syncing up to OneCRL-Tools' stable tag was part of the milestone v3.1.2 release. Since that can't wait much longer, I am inclined to move this over to v3.1.3.

@cr cr modified the milestones: v3.1.3, v3.1.2 Aug 9, 2017
@cr
Copy link
Contributor Author

cr commented Aug 15, 2017

Upstream tag has been fixed. This is now RTL. Thumbs up, @mwobensmith?

mwobensmith
mwobensmith approved these changes Aug 16, 2017
View reviewed changes
Copy link
Contributor

@mwobensmith mwobensmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@cr
Copy link
Contributor Author

cr commented Oct 20, 2017

How embarrassing. I missed to land this one. Should be good to land, but I'd wait for OneCRL-Tools's stable tag to move to mozilla/OneCRL-Tools@3bf3462 or a later commit.

@cr cr force-pushed the issue62_onecrltag branch from 2dce037 to 1d1881b Compare November 28, 2017 15:29
@cr
Copy link
Contributor Author

cr commented Nov 28, 2017

Rebased the patch and finally advanced OneCRL-Tools' stable tag to a commit that works in TLS Canary. Travis should finally go green on this in a couple of minutes.

@cr cr merged commit 3907c96 into mozilla:master Nov 28, 2017
@cr cr deleted the issue62_onecrltag branch November 28, 2017 16:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mwobensmith mwobensmith mwobensmith approved these changes

Assignees

@cr cr

Labels
None yet
Projects
None yet
Milestone
v3.1.3
Development

Successfully merging this pull request may close these issues.

Sync to tag or revision for OneCRLTools
2 participants
@cr @mwobensmith