Skip to content

Change Pandas on Polars package #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

alinzh
Copy link

@alinzh alinzh commented Dec 14, 2024

  • change Pandas on Polars package
  • update existing tests, add tests for export MPDS

@pep8speaks
Copy link

pep8speaks commented Dec 14, 2024

Hello @alinzh! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 9:80: E501 line too long (88 > 79 characters)

Line 37:80: E501 line too long (84 > 79 characters)
Line 128:80: E501 line too long (84 > 79 characters)
Line 134:80: E501 line too long (88 > 79 characters)
Line 151:80: E501 line too long (80 > 79 characters)
Line 153:80: E501 line too long (80 > 79 characters)
Line 165:80: E501 line too long (80 > 79 characters)

Line 39:80: E501 line too long (81 > 79 characters)
Line 103:80: E501 line too long (86 > 79 characters)
Line 109:80: E501 line too long (87 > 79 characters)
Line 221:80: E501 line too long (88 > 79 characters)
Line 222:80: E501 line too long (83 > 79 characters)
Line 292:80: E501 line too long (81 > 79 characters)
Line 415:80: E501 line too long (80 > 79 characters)

Line 11:80: E501 line too long (84 > 79 characters)
Line 16:80: E501 line too long (80 > 79 characters)
Line 23:80: E501 line too long (84 > 79 characters)
Line 28:80: E501 line too long (81 > 79 characters)
Line 46:80: E501 line too long (81 > 79 characters)

Line 18:80: E501 line too long (108 > 79 characters)
Line 61:80: E501 line too long (81 > 79 characters)
Line 86:80: E501 line too long (86 > 79 characters)
Line 112:80: E501 line too long (85 > 79 characters)
Line 118:80: E501 line too long (86 > 79 characters)
Line 129:80: E501 line too long (85 > 79 characters)
Line 141:80: E501 line too long (85 > 79 characters)
Line 159:80: E501 line too long (85 > 79 characters)
Line 170:80: E501 line too long (82 > 79 characters)

Comment last updated at 2024-12-19 18:01:22 UTC

@alinzh
Copy link
Author

alinzh commented Dec 14, 2024

This test is no longer relevant, because an error occurred in an unusual range of received data.

Also in the export_MPDS.py I replaced pickle with parquet, since polars does not support pickle

@alinzh
Copy link
Author

alinzh commented Dec 17, 2024

Perhaps it is worth adding path for saving as an optional argument?
https://github.com/mpds-io/mpds-client/blob/master/mpds_client/export_MPDS.py#L43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants