[RFC] sd_lavc: strictly letter-box DVD subtitles by default #14847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, using
--stretch-dvd-subs=yes, and--stretch-dvd-subs=nodoesn't seem to make a difference.This PR changes the default behaviour (
--stretch-dvd-subs=no) to using strict letter-boxing for DVD subtitles instead of stretching them.Strict letter-boxing is already the default for PGS subtitles since bcc3d72, so it seems to make sense for it to be the default for DVD subtitles as well.
The current behaviour can still be kept with
--stretch-dvd-subs=yes.Fixes #14276.