Skip to content

player: make effective image_display_duration playback_speed aware #16763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

player: make effective image_display_duration playback_speed aware #16763

wants to merge 1 commit into from

Conversation

MoSal
Copy link
Contributor

@MoSal MoSal commented Sep 6, 2025

As titled.

sfan5
sfan5 reviewed Sep 6, 2025
View reviewed changes
@MoSal MoSal force-pushed the image_display_duration_speed_aware branch from b2a7b6e to caff7ae Compare September 6, 2025 12:37
@kasper93
Copy link
Member

kasper93 commented Sep 6, 2025

probably fine, but we really need to remove this time_frame hack...

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2025 •
edited
Loading

Download the artifacts for this pull request:

Windows
macOS

na-na-hi
na-na-hi reviewed Sep 6, 2025
View reviewed changes
@MoSal MoSal force-pushed the image_display_duration_speed_aware branch from caff7ae to 6e2b320 Compare September 6, 2025 15:24
@guidocella
Copy link
Contributor

Does this really make sense when you can change --image-display-duration at runtime? In mixed playlists increasing speed to decrease the slideshow duration will also increase the speed of videos. This was rejected before in #12496.

@MoSal
Copy link
Contributor Author

MoSal commented Sep 6, 2025 •
edited
Loading

Does this really make sense when you can change --image-display-duration at runtime? In mixed playlists increasing speed to decrease the slideshow duration will also increase the speed of videos.

"Mixed playlists" is exactly where this behavior will show logical consistency between images and videos. I'm not sure how that's a point against it.

Set end (at runtime if you wish to) to the same value as image-display-duration, and you will get full symmetry between the two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sfan5 sfan5 sfan5 left review comments

+1 more reviewer

@na-na-hi na-na-hi na-na-hi left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MoSal @kasper93 @guidocella @sfan5 @na-na-hi