vimhelp: add an option to split codeblocks #588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the comment above the list says it prevents ancestors from croaking on the "debug" and "verbose" options if they don't utilise those.
This introduces an option to split codeblocks as discussed in [1]. The default behaviour used to be to always split them. The new is to not, unless requested via the option split_codeblocks. Besides that the commit includes: * some refactoring * some new warnings [1]: mquinson#551
* fix a typo in "translate" and its documentation * move chdir out of update-po in case it gets skipped
|
shit! I said maybe one hour ago that we were in string freeze for the translators. Maybe we could rush this changes in before anyone reads my mail? |
|
After reviewing the code, I have the feeling that it's a bit too large to rush it in. Maybe we should do 2 releases of po4a soon. One with what's already in master, and one with this PR and the fix to some of the bugs. We may hope that I'll find more time soon to fix them... |
|
Yep, sure... There is a one big commit and a couple of minor vaguely related fixes; I can split them off into dedicated PRs if that eases the review... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces an option to split codeblocks as discussed in 1. The
default behaviour used to be to always split them. The new is to not,
unless requested via the option split_codeblocks.
Besides that the PR includes: