`OrbitControls.update()` does not respect `Controls.enabled`

[waynemwashuma]

Description

This issue came about when i tried to run two camera controls when one is enabled and the other disabled.The disabled camera still operates when controls.update() is called and overrides the other camera controls.

An easy fix is to bail out when disabled on the OrbitControls is updated

Reproduction steps

1. Create a camera.
2. Create an orbit control bound to the camera and enable it
3. Create another orbit control bound to the same camera and enable it
4. Update the controls each frame ( for this to show, you have to run the enabled camera first then the disabled )

Code

None

Live example

None

Screenshots

No response

Version

r0.181.1

Device

No response

Browser

No response

OS

No response

[Mugen87]

The controls actually works as intended. The enabled property is defined as follows in the docs:

Whether the controls responds to user input or not.

So setting enabled to false means it does not react on any events. However, calling update() is still a valid operation. Your change #32266 can have unintended side effects for applications that required update() with disabled user input. So I don't think the PR can be merged.