Skip to content

20250218 fix typo #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2025
Merged

20250218 fix typo #39

merged 2 commits into from
Feb 18, 2025

Conversation

ConnerWill
Copy link
Contributor

Description

When trying to create configurations for board: SKRME3V2, I get error:

Configurations generator script for the Professional Firmware
Author: Miguel A. Risco Castillo (c) 2022

-Process Ender3-SKRME3V2-BLTUBL-CR10DSPLY-T13/Configuration.h
-Process Ender3-SKRME3V2-BLTUBL-CR10DSPLY-T13/Configuration_adv.h
>>>> Invalid operation: Disabled
>>>> While processing file: _boards/SKRME3V2.json

An error was found while processing your request

I found that this Disabled line should just be Disable

  {
    "op": "Disabled",
    "searchfor": "CONTROLLER_FAN_PIN"
  },
-    "op": "Disabled",
+    "op": "Disable",

In addition to fixing this issue that prevented me from building the configurations for this board. I also noticed a typo for interrrupt

"comment": "Workaround to fix interrrupt handling in SKR MINIE3V2"

This one does not prevent the usage of this tool, its just another typo I found.

-    "comment": "Workaround to fix interrrupt handling in SKR MINIE3V2"
+    "comment": "Workaround to fix interrupt handling in SKR MINIE3V2"

Requirements

The issue is in the _boards/SKRME3V2.json file

Benefits

I was unable to build the configurations for board: SKRME3V2

I was able to build the configurations after making this fix.

Configurations

#!/usr/bin/python

import CreateConfigs
CreateConfigs.Generate('Ender3-SKRME3V2-BLTUBL-CR10DSPLY-T13',['Ender3','SKRME3V2','BLT','UBL','CR10DSPLY','T13'])

@mriscoc mriscoc merged commit ff8f0cb into mriscoc:main Feb 18, 2025
@ConnerWill ConnerWill deleted the 20250218_fix-typo branch February 18, 2025 20:56
@Goal60
Copy link

Goal60 commented Feb 24, 2025

Typo "interrrupt handling in SKR MINIE3..." is also in SKRME3V3

@mriscoc
Copy link
Owner

mriscoc commented Feb 25, 2025

Typo "interrrupt handling in SKR MINIE3..." is also in SKRME3V3

Fixed, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants