Skip to content

improved formatting for some files #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

andanotheruser
Copy link
Contributor

Description

Hey there,

over at work we're maintaining a fork downstream with some improved formatting, so I thought I'd upstream the changes. :)

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly. (No changes required)
  • I have added tests to cover my changes. (No changes required)
  • All new and existing tests passed.

@andanotheruser andanotheruser force-pushed the upstreaming-formatting branch 2 times, most recently from 52eee84 to a959d91 Compare October 24, 2024 09:49
@eRadical
Copy link
Collaborator

@andanotheruser - can you please rebase!

@andanotheruser
Copy link
Contributor Author

can you please rebase!

done :)

@andanotheruser
Copy link
Contributor Author

andanotheruser commented Nov 14, 2024

Pipeline fails, but this is solved by #234.

Copy link

stale bot commented Jan 15, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 15, 2025
@andanotheruser
Copy link
Contributor Author

@andanotheruser - can you please rebase!

I rebased as requested. Could you please review the MR so that the bot does not close it because of inactivity? :)

@stale stale bot removed the wontfix label Jan 16, 2025
@eRadical
Copy link
Collaborator

LGTM, @elcomtik || @mrlesmithjr ?

@elcomtik
Copy link
Collaborator

I like almost everything except complex when cluasules which were formatted to one line

@elcomtik
Copy link
Collaborator

I like almost everything except complex when clauses were formatted to one line

@andanotheruser I think this complex when clauses are better readable multiline

@andanotheruser
Copy link
Contributor Author

I like almost everything except complex when cluasules which were formatted to one line

(@elcomtik @mrlesmithjr done)

@elcomtik elcomtik merged commit f44a952 into mrlesmithjr:master Feb 5, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants