Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added extra coloring options #193

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

The-EDev
Copy link

variables added:

  • color-trackers-text: this allows the text of the "tracker" column in the issue list to be the same color as the issue's tracker.
  • color-status-text: same as above but for status column.
  • color-id-trackers: replaces the color-trackers variable.
  • color-id-status: works the same as color-id-trackers, but uses the status colors instead.

status colors added:

  • Resolved: Green
  • Feedback: Yellow
  • Rejected: Dark Red

notes:

  • I left the in progress color the same as primary, but feel free to suggest changes.
  • The added variables are all set to false by default except color-id-trackers, so it should initially look the same as the default theme.
  • I tested the teme changes with redmine 3.4 and 4.0, both of which seemed to work fine.
  • I'm not familiar with pull requests so please let me know if i messed up anything :D

Related issue:
#192

The-EDev added 3 commits May 23, 2020 20:02
the options allow for the text of the status and tracker to be the color of the status or tracker, also allows coloring the id by either the status or tracker, in addition to adding colors for resolved, feedback, and rejected statuses
Copy link
Owner

@mrliptontea mrliptontea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this! Good job on putting this PR.

Note: I have not tested this yet, will give it a go soon.

For now, I have only some technical notes:

  1. Formatting is a bit funky in a few places. If you merge the latest changes from the main repo, I included some changes to run linters via git pre-commit hooks. Also, they should now run in GitHub actions for PRs from forks, I think.
  2. I'm not sure about changes in other .css files, looks like some vendor prefixes were not applied (added by autoprefixer in postcss) - did you compile the changes with grunt sass? You should run grunt build, but with the pre-commit hooks from above, you should be able to just git commit and it'll run automatically.

@The-EDev
Copy link
Author

I seem to not have applied the changes to the redmine_blacklogs plugin, I'll need to check that before running grunt build

@The-EDev The-EDev marked this pull request as draft July 19, 2020 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coloring issues by status + coloring the text of tracker / status in issues menu
2 participants