fix: make sure assert.throws uses our assert proxy

[jembezmamy]

This MR adds missing assert.throws compatibility.

In the contrast to other assert methods, assert.throws doesn't use our assert proxy. It reaches for currentTest.assert, which is the original assert object.

The issue can be fixed by overriding the test.assert property with our proxy.

[mrloop]

I'm not sure but could this be done differently, it feels like we'd be able to intercept throws in our Proxy and then handle it correctly there?

[jembezmamy]

I think we would need to copy whole assert.throws source code and rewrite it in such way, that it uses our assert proxy instead of currentTest.assert.

Another option to investigate is to create test proxy and expose it in assert proxy. And then override test.assert to point back to our proxy. But I'm not sure if it would work (I think I already investigated this option, but I don't remember the details). What's more, config.current still points to a test that has no knowledge about our proxy. So if some custom assertion uses config.current.assert, it won't work with qunit-retry.

So the bottom line is that I don't see any simple alternative solution. :(

[mrloop]

👍🏻 thanks for the explanation, I agree this looks like the simplest, maybe only solution, feels a bit brittle though :(