Get MySQL, Mroonga, and Groonga versions automatically in update.sh #98
+34
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usage: ./update.sh
otegami
reviewed
Jan 30, 2025
update.sh
Outdated
| if [ $# != 3 ]; then | ||
| echo "Usage: $0 MYSQL_VERSION MROONGA_VERSION GROONGA_VERSION" | ||
| echo " e.g.: $0 8.0.30 12.06 12.0.6" | ||
| if [ $# != 0 ]; then |
There was a problem hiding this comment.
引数を受け取らない場合は、ここのチェックはなくても良さそうかなと思いました。
otegami
reviewed
Jan 30, 2025
| mysql_version=$1 | ||
| mroonga_version=$2 | ||
| groonga_version=$3 | ||
| target_mysqls=( |
There was a problem hiding this comment.
Suggested change
| target_mysqls=( | |
| target_mysql_versions=( |
There was a problem hiding this comment.
Sorry this is right. Please ignore my comment.
This reverts commit 71c467f.
otegami
reviewed
Jan 30, 2025
update.sh
Outdated
| 8.0) | ||
| mysql_version=$(curl https://raw.githubusercontent.com/docker-library/mysql/refs/heads/master/versions.json \ | ||
| | jq -r '.["8.0"]["version"]') | ||
| docker_file=mysql-8.0/Dockerfile |
There was a problem hiding this comment.
We might write this line outside the case block.
otegami
reviewed
Jan 30, 2025
update.sh
Outdated
|
|
||
| tag="mysql-${mysql_version}-${mroonga_version}" | ||
| message="MySQL ${mysql_version} and Mroonga ${mroonga_version}" | ||
| echo "${message}" |
There was a problem hiding this comment.
Is this debug command? If so, we could delete it.
otegami
approved these changes
Jan 30, 2025
kou
reviewed
Jan 30, 2025
Co-authored-by: Sutou Kouhei <[email protected]>
I updated it. |
abetomo
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage:
./update.shThe result of execution of
./update.shas below.Date: Thu Jan 30 11:29:55 2025 +0900 MySQL 8.0.41 and Mroonga 14.13 diff --git a/README.md b/README.md index 7c5ad8d..2397169 100644 --- a/README.md +++ b/README.md @@ -35,7 +35,8 @@ Currently, groonga/mroonga provides these couples of versions. | tag | MySQL | Mroonga | Groonga | |------------------------|--------|---------|---------| -| mysql-8.0-latest | 8.0.40 | 14.12 | 14.1.2 | +| mysql-8.0-latest | 8.0.41 | 14.13 | 14.1.3 | +| mysql-8.0.41-14.13 | 8.0.41 | 14.13 | 14.1.3 | | mysql-8.0.40-14.12 | 8.0.40 | 14.12 | 14.1.2 | | mysql-8.0.30-12.06 | 8.0.30 | 12.06 | 12.0.6 | | mysql-8.0.29-12.04 | 8.0.29 | 12.04 | 12.0.4 | diff --git a/mysql-8.0/Dockerfile b/mysql-8.0/Dockerfile index ed6b805..e7fbbec 100644 --- a/mysql-8.0/Dockerfile +++ b/mysql-8.0/Dockerfile @@ -1,4 +1,4 @@ -FROM mysql:8.0.40-oraclelinux9 +FROM mysql:8.0.41-oraclelinux9 # TODO # Remove `--setopt=apache-arrow-almalinux.gpgcheck=0` option. @@ -8,8 +8,8 @@ FROM mysql:8.0.40-oraclelinux9 # error: failed to parse public key for /var/cache/yum/metadata/apache-arrow-almalinux-9-x86_64/RPM-GPG-KEY-Apache-Arrow # ``` -ENV groonga_version=14.1.2 \ - mroonga_version=14.12 +ENV groonga_version=14.1.3 \ + mroonga_version=14.13 RUN mkdir -p /etc/mysql/mysql.conf.d && \ touch /etc/mysql/mysql.conf.d/default-auth-override.cnf && \ @@ -33,6 +33,6 @@ RUN mkdir -p /docker-entrypoint-mroonga-initdb.d && \ -e 's,docker_process_init_files /,docker_process_init_files /docker-entrypoint-mroonga-initdb.d/* /,g' \ /usr/local/bin/docker-entrypoint.sh -# mysql:8.0.40 image has DB in /var/lib/mysql/. +# mysql:8.0.41 image has DB in /var/lib/mysql/. # This clears /var/lib/mysql/ to ensure creating a new DB on "docker run". VOLUME ["/var/lib/mysql"]