fix: Update cpp code to support React Native 0.75.1 #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
quite a breaking change 😅 |
|
please run clang format. |
|
Both iOS and Android builds failed now, so this PR is definitely not backwards compatible. I don't want to introduce a lot of new code with People will complain either way |
|
I think that it is perfectly fine to do that. I am content using the patch I created that was posted in the original issue, and I think that will work well for anyone that needs support for 75.1+. Once that version gains more traction these changes can be integrated into the main branch. Thanks for taking the time to look at it. |
|
Awesome work, was experiencing the same thing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates cpp code to rename some variables to meet new CodeGen specifications