Skip to content

fix: "Identifier 'module' has already been declared" on web v3.0.2 #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 9, 2024

Conversation

arasrezaei
Copy link
Contributor

when using react compiler with expo, i got this error on web:
Identifier 'module' has already been declared
simply renaming that module to Module fixed the issue.

change module variable name to Module
change module variable name to Module
@arasrezaei arasrezaei changed the title fix "Identifier 'module' has already been declared" on web v3.0.2 fix: "Identifier 'module' has already been declared" on web v3.0.2 Sep 8, 2024
@mrousavy
Copy link
Owner

mrousavy commented Sep 9, 2024

Ah interesting! Instead of Module, can you please rename it to mmkvModule and mmkvPlatformModule (respectively)? Variables shouldn't start with uppercase letters.

change variable name to mmkvPlatformModule
rename to mmkvModule
@mrousavy mrousavy merged commit 437fd33 into mrousavy:main Sep 9, 2024
2 of 3 checks passed
@mrousavy
Copy link
Owner

mrousavy commented Sep 9, 2024

Awesome, thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants