-
Notifications
You must be signed in to change notification settings - Fork 11
Add markdown report & badge #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@mrverdant13 can you review please when you have the time? |
Hi, @easazade 👋🏻 |
Hi again, @easazade I've been thinking of this feature. ConcernMy main concern about the current implementation is that this feature is not optional when generating reports. Another potential usability hustle that may arise is the increased complexity that would be introduced in a single command that was initially created for a single purpose. This would result in a set of optional command options and flags with cumbersome relationships, constraints and conditions, that would definitely hinder testability. So, I am open to discuss a new approach that may handle this with a better approach. ProposalUsing
|
@mrverdant13 Thanks for the review. I can add sub commands In general I would suggest not to add a lot of stuff to the scope of this PR. but it's your repo you make the decision. |
@easazade |
This PR updates the report command to also generate a markdown report and a github badge based on the given thresholds.
markdown report is a one page compact report with a short summary that can be used in pull requests to show a short report of the code coverage
example of the generated markdown reprot
