Skip to content

Rename --lp option to --mip and keep --lp as an alias #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 16, 2025

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Rename --lp option to --mip and keep --lp as an alias

toysat, toysolver, and toysolver_check commands have --lp option, which turns them into a mode for solving/processing MIP problems in LP files (*.lp) or MPS files (*.mps).

Initially, only the LP file was supported, so the option was named --lp. But since we now support MPS files as well, the name --mip is more appropriate.

This PR renames the option to --mip while keeping --lp as an alias for backward compatibility.

Link to Devin run: https://app.devin.ai/sessions/ef4c684380234ef1aef7399c9b139888
Requested by: [email protected]

Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Copy link
Owner

@msakai msakai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's not necessary to mention the deprecated option in README.md.

Could you remove the mention of the --lp option from README.md ?

Copy link
Owner

@msakai msakai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@msakai msakai merged commit 027e9fe into master May 16, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant