Skip to content

Conversation

@Dogacel
Copy link
Contributor

@Dogacel Dogacel commented Aug 3, 2023

No description provided.

@mscheong01
Copy link
Owner

Hi @Dogacel, What do you think should be the expected output when recursive proto messages are defined? With our current API, this stackoverflowerror seems inevitable, unless #9 is implemented

@Dogacel
Copy link
Contributor Author

Dogacel commented Aug 8, 2023

Hi @Dogacel, What do you think should be the expected output when recursive proto messages are defined? With our current API, this stackoverflowerror seems inevitable, unless #9 is implemented

Technically, a recursive proto message is never serializable thus I see two options other than #9:

  1. Error during code-generation for never serializable / initiliazible objects.
  2. Automatically infer nullability for recursive objects.

The error I demonstrate should be the last resort, in my personal opinion, I think users should know this beforehand either by seeing the nullable type of getting an error during code-generation. For example you can allow skipping erroneous code.

@mscheong01 mscheong01 force-pushed the main branch 2 times, most recently from fcbd597 to e4690e8 Compare September 9, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants