add unit test for action_flags_command

plugins/module_utils/universal.py

@@ -7,7 +7,7 @@
 import yaml
 
 
-def action_flags_command(command: list[str], flags: set[str] = {}, action_flags_map: dict[str, str] = {}) -> list[str]:
+def action_flags_command(command: list[str], flags: set[str] = [], action_flags_map: dict[str, str] = {}) -> list[str]:
     """convert action flags dict into list of command strings"""
     # in this function command list is mutable pseudo-reference and also returned
 

tests/unit/plugins/module_utils/test_universal.py

@@ -15,6 +15,20 @@ def test_validate_json_yaml_file():
         assert not universal.validate_json_yaml_file('.gitignore')
 
 
+def test_action_flags_command():
+    """test action flags dict to list of command strings converter"""
+    # test accurate flags conversion
+    assert universal.action_flags_command(['hello'], ['foo', 'bar'], {'foo': '--foo', 'bar': '--bar'}) == ['hello', '--foo', '--bar']
+
+    # test unsupported flag input
+    with pytest.warns(RuntimeWarning, match='Unsupported flag specified: baz'):
+        assert universal.action_flags_command(['hello'], ['foo', 'baz'], {'foo': '--foo', 'bar': '--bar'}) == ['hello', '--foo']
+
+    # test action with no action flags input
+    with pytest.warns(RuntimeWarning, match='Unsupported flag specified: foo'):
+        assert universal.action_flags_command(['hello'], ['foo'], {}) == ['hello']
+
+
 def test_vars_converter():
     """test ansible vars param to hashi cli converter"""
     # test accurate vars conversion