Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libgit2: update to 1.8.4 #20396

Merged
merged 6 commits into from
Nov 10, 2024
Merged

libgit2: update to 1.8.4 #20396

merged 6 commits into from
Nov 10, 2024

Conversation

podsvirov
Copy link
Collaborator

No description provided.

@Biswa96
Copy link
Member

Biswa96 commented Mar 21, 2024

Reverse dependencies need pkgrel bump.

@podsvirov
Copy link
Collaborator Author

Of course you're right. I'll try to do this soon. But I don't mind if someone does it while I'm a little busy with other things.

@lazka lazka marked this pull request as draft March 21, 2024 07:58
@podsvirov
Copy link
Collaborator Author

Reverse dependencies need pkgrel bump.

I've done a little analysis and it seems the world is not ready for this update yet :-).
We need to wait a bit for the dependent packages to support this version.

@ognevny
Copy link
Collaborator

ognevny commented Jun 26, 2024

IMO it's ok to push an update to 1.8.1 and rebuilds for reverse dependencies. Arch already did this

@podsvirov podsvirov changed the title libgit2: update to 1.8.0 libgit2: update to 1.8.1 Jun 27, 2024
@podsvirov
Copy link
Collaborator Author

Updated to 1.8.1.

$ pacboy  -Sii libgit2:u
...
Required By     : mingw-w64-ucrt-x86_64-bat  mingw-w64-ucrt-x86_64-cargo-c  mingw-w64-ucrt-x86_64-cargo-generate  mingw-w64-ucrt-x86_64-delta
                  mingw-w64-ucrt-x86_64-fritzing  mingw-w64-ucrt-x86_64-geany-plugins  mingw-w64-ucrt-x86_64-gitui  mingw-w64-ucrt-x86_64-jj
                  mingw-w64-ucrt-x86_64-kicad  mingw-w64-ucrt-x86_64-ktexteditor-qt5  mingw-w64-ucrt-x86_64-libgit2-glib  mingw-w64-ucrt-x86_64-lsd
                  mingw-w64-ucrt-x86_64-python-pygit2  mingw-w64-ucrt-x86_64-zed
...

Should we rebuild all these packages or something else?

@ognevny
Copy link
Collaborator

ognevny commented Jun 27, 2024 •
edited
Loading

Updated to 1.8.1.

$ pacboy  -Sii libgit2:u
...
Required By     : mingw-w64-ucrt-x86_64-bat  mingw-w64-ucrt-x86_64-cargo-c  mingw-w64-ucrt-x86_64-cargo-generate  mingw-w64-ucrt-x86_64-delta
                  mingw-w64-ucrt-x86_64-fritzing  mingw-w64-ucrt-x86_64-geany-plugins  mingw-w64-ucrt-x86_64-gitui  mingw-w64-ucrt-x86_64-jj
                  mingw-w64-ucrt-x86_64-kicad  mingw-w64-ucrt-x86_64-ktexteditor-qt5  mingw-w64-ucrt-x86_64-libgit2-glib  mingw-w64-ucrt-x86_64-lsd
                  mingw-w64-ucrt-x86_64-python-pygit2  mingw-w64-ucrt-x86_64-zed
...

Should we rebuild all these packages or something else?

look at package-grokker output first. at least don't rebuild zed, as there is a update PR for it: #21254

upd.: for rust packages you need to update git2 crate to 0.19.0

@ognevny
Copy link
Collaborator

ognevny commented Jun 28, 2024

cargo update -p git2 --precise 0.19.0 doesn't work? I think there is no need for a patch

@podsvirov
Copy link
Collaborator Author

cargo update -p git2 --precise 0.19.0 doesn't work? I think there is no need for a patch

    Updating crates.io index
error: failed to select a version for the requirement `git2 = "^0.18"`
candidate versions found which didn't match: 0.19.0

@podsvirov
Copy link
Collaborator Author

Hm, clang64 (but not for others) failed for lsd::

  ==> Validating source files with sha256sums...
      lsd-1.1.2.tar.gz ... Passed
      1021.patch ... FAILED
      0001-lsd-1.1.2-update-git2.patch ... Passed

@ognevny
Copy link
Collaborator

ognevny commented Jun 29, 2024

Hm, clang64 (but not for others) failed for lsd::

  ==> Validating source files with sha256sums...
      lsd-1.1.2.tar.gz ... Passed
      1021.patch ... FAILED
      0001-lsd-1.1.2-update-git2.patch ... Passed

change it to upstream commit: lsd-rs/lsd@575f505

@podsvirov podsvirov force-pushed the libgit2-update branch 2 times, most recently from a2d279b to b074487 Compare June 30, 2024 04:40
@podsvirov podsvirov force-pushed the libgit2-update branch 7 times, most recently from 86317e7 to a50f270 Compare October 20, 2024 08:29
@podsvirov podsvirov changed the title libgit2: update to 1.8.1 libgit2: update to 1.8.2 Oct 20, 2024
@podsvirov podsvirov changed the title libgit2: update to 1.8.2 libgit2: update to 1.8.1 Oct 20, 2024
@podsvirov podsvirov changed the title libgit2: update to 1.8.1 libgit2: update to 1.8.4 Oct 31, 2024
@lazka lazka mentioned this pull request Nov 10, 2024
Closed
podsvirov and others added 5 commits November 10, 2024 16:23
@podsvirov @lazka
libgit2: update to 1.8.4
a86721c
@podsvirov @lazka
python-pygit2: update to 1.16.0
aff7fbc
@podsvirov @lazka
cargo-generate: update to 0.22.0
751c809
@lazka
pygit2: backport build fix
a92f7d1
@lazka
Remaining libgit2 rebuilds
2921e23 
* All the rust projects are still depending on the old version, so use
the vendored libgit2
* libgit2-glib: add patch from PR, upstream is inactive
* geany/fritzing: seems to build fine
* kicad: got support with the last patch release
@lazka lazka marked this pull request as ready for review November 10, 2024 18:55
@lazka lazka merged commit dda6ad3 into msys2:master Nov 10, 2024
5 of 7 checks passed
@lazka lazka mentioned this pull request Nov 11, 2024
Open
5 tasks
@podsvirov
Copy link
Collaborator Author

@lazka, thanks for done (or start...) this work! :-)

@podsvirov podsvirov deleted the libgit2-update branch November 11, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@podsvirov @Biswa96 @ognevny @lazka