Skip to content

Drop clang32 #21998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Drop clang32 #21998

merged 1 commit into from
Dec 17, 2024

Conversation

MehdiChinoune
Copy link
Collaborator

It has no use.

@ognevny
Copy link
Collaborator

ognevny commented Sep 21, 2024

@mati865 issues with i686-pc-windows-gnullvm will be solved after this PR!

@Biswa96
Copy link
Member

Biswa96 commented Sep 21, 2024

OK from me. But I would like to wait for all others opinion too.

@mati865
Copy link
Collaborator

mati865 commented Sep 22, 2024

@mati865 issues with i686-pc-windows-gnullvm will be solved after this PR!

I don't see how it's correlated.

@ognevny
Copy link
Collaborator

ognevny commented Sep 22, 2024

no clang32, no need to solve it in this repo

@mati865
Copy link
Collaborator

mati865 commented Sep 22, 2024

And what's the problem?

@ognevny
Copy link
Collaborator

ognevny commented Sep 22, 2024

And what's the problem?

compile error from #21902 (comment)

@mati865
Copy link
Collaborator

mati865 commented Sep 22, 2024

Although we don't package them any longer, so that shouldn't be a problem, I suppose.

It won't be a problem because we don't build them on the CI.

@lazka
Copy link
Member

lazka commented Sep 22, 2024

Fair enough I guess.

With 32bit going away and clang32 not seeing much use it's probably not worth the effort.

I'd still prefer to create a NEWS entry for this first and phase out in chunks with a timeline. I'll have a look later.

lazka added a commit that referenced this pull request Sep 23, 2024
See #21998
and msys2/msys2.github.io@89521b9

This is the first batch of removals to start things off.
@lazka
Copy link
Member

lazka commented Sep 23, 2024

I've added a NEWS entry in msys2/msys2.github.io@89521b9

and removed some packages without rdepends in 1e7737f

I am wondering if keeping a minimal toolchain/language package set around for longer would still be useful.

@MehdiChinoune MehdiChinoune force-pushed the drop-clang32 branch 2 times, most recently from b471089 to 6c024d3 Compare September 23, 2024 10:23
@MehdiChinoune
Copy link
Collaborator Author

OK to merge?

@MehdiChinoune MehdiChinoune force-pushed the drop-clang32 branch 2 times, most recently from 0d08780 to de43ae8 Compare October 5, 2024 07:21
@mati865 mati865 mentioned this pull request Oct 16, 2024
@ognevny
Copy link
Collaborator

ognevny commented Oct 17, 2024

@MehdiChinoune feel free to drop all reverse dependencies of Rust now (with separate commits/PRs). I will drop CLANG32 Rust in #22205

@MehdiChinoune
Copy link
Collaborator Author

MehdiChinoune commented Oct 17, 2024

Dropping rust on clang32 means practically dropping all the packages (which is the goal of this PR)

@ognevny
Copy link
Collaborator

ognevny commented Oct 17, 2024

Dropping rust on clang32 means practically dropping all the packages (which is the goal of this PR)

uh oh. currently there is no way to fix CLANG32 rustc, so no choice for me (I don't want to block update)

@MehdiChinoune
Copy link
Collaborator Author

I will try to rebuild some packages without extra/optional dependencies.

@MehdiChinoune
Copy link
Collaborator Author

Only remaining packages are the toochain ones.

Could we press the button and drop clang32.
Any objection?

@Biswa96
Copy link
Member

Biswa96 commented Dec 9, 2024

If there is no maintenance burden, I think, the llvm toolchain should be kept for any compiler testing purposes like llvm-mingw or for mingw-w64 testing etc.

@MehdiChinoune
Copy link
Collaborator Author

If there is no maintenance burden, I think, the llvm toolchain should be kept for any compiler testing purposes like llvm-mingw or for mingw-w64 testing etc.

Isn't llvm-mingw already doing this job?
A contributor of both LLVM and mingw-w64 maintaining LLVM+mingw-w64 (llvm-mingw) for different architectures (i686, x86_64, aarch64, arm).

@mati865
Copy link
Collaborator

mati865 commented Dec 9, 2024

If there is no maintenance burden, I think, the llvm toolchain should be kept for any compiler testing purposes like llvm-mingw or for mingw-w64 testing etc.

It causes problems at least once a year, typically with LLVM major version upgrade. Recently it's been hitting issues with insufficient available address space for 32-bit programs.

@MehdiChinoune MehdiChinoune merged commit fe16a8e into msys2:master Dec 17, 2024
0 of 6 checks passed
@MehdiChinoune MehdiChinoune deleted the drop-clang32 branch December 17, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants