Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix out-of-bounds textures in [combine #28

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Conversation

OgelGames
Copy link
Contributor

Third attempt at fixing the issue, in my testing it fixes every case of overflow.

Comparison of signs before and after the fixes:

image

Fixes #24

@OgelGames OgelGames added enhancement New feature or request bugfix fixes a bug labels Apr 19, 2024
Copy link
Member

@Athozus Athozus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@SmallJoker
Copy link

A sign on a server that caused the warnings:
grafik

The same sign, after saving the mapblocks locally and using the patched signs_lib. The warnings are now gone.
grafik

Copy link

@SmallJoker SmallJoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my machine.

@OgelGames OgelGames merged commit 3d5ba32 into master Apr 22, 2024
2 checks passed
@OgelGames OgelGames deleted the out-of-bounds-fix branch April 22, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix fixes a bug enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

out-of-bounds combine textures
3 participants