Skip to content

Apply patches via the actually used poetry #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

stevapple
Copy link
Contributor

In a ConsoleCommandEvent handler, where patches are applied, we sometimes get a different poetry project (probably by other plugins) from the one that the plugin is originally invoked. This patch changes the so that the plugin will apply to all the Poetry projects that are being used.

In a `ConsoleCommandEvent` handler, where patches are applied, we sometimes get a different `poetry` project (probably by other plugins) from the one that the plugin is originally invoked. This patch changes the so that the plugin will apply to all the Poetry projects that are being used.
@mtkennerly
Copy link
Owner

Thanks! :D

@mtkennerly mtkennerly merged commit 549fb80 into mtkennerly:master Mar 4, 2025
37 checks passed
mtkennerly added a commit that referenced this pull request Mar 4, 2025
@mtkennerly mtkennerly added the bug Something isn't working label Mar 4, 2025
@mtkennerly mtkennerly added this to the v1.8.0 milestone Mar 21, 2025
@mtkennerly
Copy link
Owner

This is now released in 1.8.0 🎉

@elventear
Copy link

elventear commented Mar 28, 2025

Recently upgraded this library in my setups and this is breaking poetry. No commands can be executed, be they native to poetry or a plugin, for example. Reverting to <1.8 solves the problem.

> poetry list
'ListCommand' object has no attribute 'poetry'

@mtkennerly
Copy link
Owner

mtkennerly commented Mar 28, 2025

@elventear Thanks for reporting that. I can reproduce it as well. I guess it happens with specific commands - list fails, but build works for me. I'll add a test to cover that and add some fallback functionality.

mtkennerly added a commit that referenced this pull request Mar 28, 2025
@mtkennerly
Copy link
Owner

That error should be fixed now in v1.8.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants