Remove extra lines that cause the testsuite to fail in 1.8.2#229
Closed
baldurmen wants to merge 1 commit intomtkennerly:masterfrom
Closed
Remove extra lines that cause the testsuite to fail in 1.8.2#229baldurmen wants to merge 1 commit intomtkennerly:masterfrom
baldurmen wants to merge 1 commit intomtkennerly:masterfrom
Conversation
Owner
|
Hi! The tests on master pass for me locally (Windows) as well as in CI, and it looks like the changes here fail in CI. I'm not sure what's causing the failure when you ran it, though. How are you running the tests exactly, and which version of Poetry/tomlkit is it using? There are also a couple of environment variables that can affect the tests, seen here: poetry-dynamic-versioning/tasks.py Lines 63 to 67 in 646771a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While updating the Debian package to 1.8.2, I encountered this testsuite failure:
I was able to reproduce this in a venv with packages from pip too. The extra
[tool]lines looked odd to me and the testsuite passes without them.I'm guessing it was an oversight?