Replacing MEMORYSIZE with MEMORY_MIN and MEMORY_MAX #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removing MEMORYSIZE and adding MEMORY_MIN and MEMORY_MAX
this way people can set the -Xms and the -Xmx separately
removing MEMORY and adding MEMORY_MIN and MEMORY_MAX
notkudu
changed the title
|
thanks, but this was a breaking change for all existing deployments and can't be merged. also this are no min or max values. |
I see, I know this is no min and max value. I just wanted to seat a low initial heap and allow the server to use more memory as it needs |
|
hey, the new changes should not break existing deployments :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets people set the "-Xms" and "-Xmx" separately :)