Use require_relative
#90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@koic Thank you, can you rebase the branch onto the latest main? |
|
Thank you for the review. It seems possible to update the |
This PR uses `require_relative` instead of `require`. It prevents redundant searches due to the size of `$LOAD_PATH`.
koic
force-pushed
the
use_require_relative
branch
from
e66debf to
d0237c4
Compare
|
I've updated the changes as mentioned above. Please let me know if there are any issues, and I will revert them. |
|
It seems the benchmark workflow has a problem with forked repo though, I'll merge this PR. Thanks! |
mtsmfm
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses
require_relativeinstead ofrequire. It prevents redundant searches due to the size of$LOAD_PATH.NOTE: Changes that seem to eliminate the need forrequireare addressed in #89.