-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Refine and polish out Templates page #43131
Conversation
Netlify deploy preview
Bundle size report |
@samuelsycamore would you mind doing a pass-through on this page content and also the templates to detect any typos or improvements? |
@siriwatknp I think the Argos test is detecting many screenshots from the marketing page template (old landing page template). Could this be related to the new screenshot script? Otherwise, can I approve the Argos test? |
Just a small bump on this one, I need to merge it to start working on the theme unification and consistency @siriwatknp @DiegoAndai @samuelsycamore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
text looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might need to revisit the regression tests for templates next. I encounter unrelated Argos changes in other PRs from templates (especially with charts) multiple times.
This PR addresses some items from #41469 :
12. Rename the “landing page” template given it looks more like a home page
14. Allow to click on the image to open it. Uploading Screen Recording 2024-06-10 at 18.14.18.mov…
The changes made were:
landing-page
tomarketing-page
(that's why there are so many files changed)Pricing
andStickyFooter
templatesCardImage