Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for v6 stable release #43454

Merged
merged 14 commits into from
Aug 27, 2024
Merged

Prepare for v6 stable release #43454

merged 14 commits into from
Aug 27, 2024

Conversation

siriwatknp
Copy link
Member

Revert 3 commits that started the next branch:


@siriwatknp siriwatknp added the core Infrastructure work going on behind the scenes label Aug 26, 2024
The `next` tag is used to download the latest <b>pre-release</b>, v6 version. Remove it to get the current stable version.
:::

<!-- #default-branch-switch -->
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mnajdova Should we keep this for future alpha?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can comment it and keep it

Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Overall looks good, I pointed out some default-branch-switch removals that likely came from reverting #41552, but I think we should keep. I don't think we should keep the mui-joy, mui-base, or styles ones, so I didn't point those out.

Copy link
Member

@aarongarciah aarongarciah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update all of next.mui.com links in the components/hooks comments in this PR? e.g. https://github.com/mui/material-ui/blob/master/packages/mui-lab/src/TabList/TabList.d.ts#L25

Comment on lines +201 to +203
npx @mui/codemod@latest v6.0.0/styled <path/to/folder-or-file>
npx @mui/codemod@latest v6.0.0/sx-prop <path/to/folder-or-file>
npx @mui/codemod@latest v6.0.0/theme-v6 <path/to/theme-file>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is @latest required here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I believe. The @latest ensure the user get the latest update of the codemod.

@mnajdova
Copy link
Member

mnajdova commented Aug 26, 2024

Should we update all of next.mui.com links in the components/hooks comments in this PR? e.g. https://github.com/mui/material-ui/blob/master/packages/mui-lab/src/TabList/TabList.d.ts#L25

Yes, let me update the script. Done in 5062c7a

@mnajdova
Copy link
Member

We should update the "Upgrade to v6 guide" to use v5 and v6 instead of master and next as terms.

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find anything else :) Let's do this 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants