[internal] useAutocomplete should have 'use client'#43778
Merged
oliviertassinari merged 1 commit intomui:masterfrom Sep 17, 2024
Merged
[internal] useAutocomplete should have 'use client'#43778oliviertassinari merged 1 commit intomui:masterfrom
oliviertassinari merged 1 commit intomui:masterfrom
Conversation
oliviertassinari
added
type: bug
Netlify deploy previewhttps://deploy-preview-43778--material-ui.netlify.app/ Bundle size report |
This was referenced Sep 15, 2024
oliviertassinari
changed the title
DiegoAndai
approved these changes
Sep 17, 2024
Member
DiegoAndai
left a comment
DiegoAndai
left a comment
There was a problem hiding this comment.
Next.js v15.0.0-rc.0: hook with "use client" 🔴 (seems to be a recent regression)
Are they fixing this? Is there an issue reported?
Member
Author
|
@DiegoAndai I can't find anything related to it. The closest that I can find: vercel/next.js#69159. 👍 to open a new issue. I won't have the time for it, but feel free to, e.g. Jan opened a few https://github.com/vercel/next.js/issues/created_by/janpot. |
oliviertassinari
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #41956 (comment).
If from a server component, we import a hook, then different behaviors can happen:
Based on the different cases 🔴/🟡/🟢, it looks like we should have "use client" for hooks too. It yields the best DX.