fix(FormHelperText): Add missing data-* attributes to typings (#47230)#47288
Closed
amarnath-cdr wants to merge 1 commit intomui:masterfrom
Closed
fix(FormHelperText): Add missing data-* attributes to typings (#47230)#47288amarnath-cdr wants to merge 1 commit intomui:masterfrom
amarnath-cdr wants to merge 1 commit intomui:masterfrom
Conversation
Netlify deploy previewhttps://deploy-preview-47288--material-ui.netlify.app/ Bundle size report
|
zannager
added
type: new feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request addresses the issue where TypeScript typings for the
FormHelperTextcomponent were incorrectly stripping or not accounting for genericdata-*attributes (likedata-testid,data-custom-id, etc.) when used in a Material UI application.The fix involves adding a dynamic index signature to the
FormHelperTextOwnPropsinterface inpackages/mui-material/src/FormHelperText/FormHelperText.d.ts.The added signature is: