Skip to content

[code-infra] make sure to always clean up fake timers #47413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
+18 −9
Draft

[code-infra] make sure to always clean up fake timers #47413

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 18 additions & 9 deletions packages-internal/test-utils/src/createRenderer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,15 @@ function createClock(
vi.setSystemTime(config);
}
});

afterEach(async () => {
if (vi.isFakeTimers()) {
await rtlAct(async () => {
vi.runOnlyPendingTimers();
});
vi.useRealTimers();
}
});
} else {
beforeEach(() => {
if (config) {
Expand All @@ -229,15 +238,6 @@ function createClock(
});
}

afterEach(async () => {
if (vi.isFakeTimers()) {
await rtlAct(async () => {
vi.runOnlyPendingTimers();
});
vi.useRealTimers();
}
});

return {
withFakeTimers: () => {
if (vi.isFakeTimers()) {
Expand Down Expand Up @@ -266,6 +266,15 @@ function createClock(
vi.setSystemTime(config);
}
});

afterEach(async () => {
if (vi.isFakeTimers()) {
await rtlAct(async () => {
vi.runOnlyPendingTimers();
});
vi.useRealTimers();
}
});
},
runToLast: () => {
rtlAct(() => {
Expand Down
Loading