Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data grid] Update filter panel input variant #15807

Merged
merged 3 commits into from
Dec 10, 2024
Merged

[data grid] Update filter panel input variant #15807

merged 3 commits into from
Dec 10, 2024

Conversation

KenanYusuf
Copy link
Member

@KenanYusuf KenanYusuf commented Dec 9, 2024 •
edited by cherniavskii
Loading

Part of #15486

Also updated the filter panel styles slightly to better accommodate the new input styles.

Single filter

Screenshot 2024-12-09 at 13 34 28

Multi filter

Screenshot 2024-12-09 at 13 35 52

Changelog

Breaking changes

  • The default variant for text fields and selects in the filter panel has been changed to outlined.

@KenanYusuf KenanYusuf added breaking change component: data grid This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer v8.x labels Dec 9, 2024
@mui-bot
Copy link

mui-bot commented Dec 9, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-15807--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 80886da

@KenanYusuf KenanYusuf requested review from a team and noraleonte December 9, 2024 13:34
noraleonte
noraleonte approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@noraleonte noraleonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks 🔥 Nice improvement!

@KenanYusuf KenanYusuf merged commit 3a67270 into mui:master Dec 10, 2024
18 checks passed
@KenanYusuf KenanYusuf deleted the filter-panel-inputs branch December 10, 2024 13:29
LukasTy pushed a commit to LukasTy/mui-x that referenced this pull request Dec 19, 2024
@KenanYusuf @LukasTy
[data grid] Update filter panel input variant (mui#15807)
5b2cf68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noraleonte noraleonte noraleonte approved these changes

@cherniavskii cherniavskii cherniavskii approved these changes

Assignees
No one assigned
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer v8.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KenanYusuf @mui-bot @cherniavskii @noraleonte