[DataGrid] Header filter design improvements #15991
Open
+456
−301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KenanYusuf
added
breaking change
component: data grid
Localization writing tips ✍️Seems you are updating localization 🌍 files. Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️
Deploy preview: https://deploy-preview-15991--material-ui-x.netlify.app/ |
KenanYusuf
commented
Dec 23, 2024
packages/x-data-grid-pro/src/components/headerFiltering/GridHeaderFilterCell.tsx
Show resolved
Hide resolved
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
KenanYusuf
commented
Dec 24, 2024
| (props.headerFilterHeight ?? props.columnHeaderHeight) * densityFactor, | ||
| const headerFilterHeight = Math.max( | ||
| Math.floor((props.headerFilterHeight ?? props.columnHeaderHeight) * densityFactor), | ||
| MIN_HEADER_FILTER_HEIGHT, |
There was a problem hiding this comment.
What do we think about adding a minimum height for the header filter row? We need at minimum enough space for the inputs to not be clipped. Would fix #13048
There was a problem hiding this comment.
(there's a broken test related to this, I'll fix if we want to move forward with this approach)
github-actions
bot
removed
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15486
https://deploy-preview-15991--material-ui-x.netlify.app/x/react-data-grid/filtering/header-filters/
Changelog
Breaking changes
slotProps={{ headerFilterCell: { showClearIcon: true } }}to restore the clear button in the cell.