Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] Add satisfies casting to slotProps #9485

Closed
wants to merge 9 commits into from

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Jun 26, 2023

Reopen #7859

@LukasTy LukasTy added typescript component: pickers This is the name of the generic UI component, not the React module! labels Jun 26, 2023
@LukasTy LukasTy self-assigned this Jun 26, 2023
@mui-bot
Copy link

mui-bot commented Jun 26, 2023

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-9485--material-ui-x.netlify.app/

Updated pages

No updates.

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 508.4 992.7 855.5 760 202.682
Sort 100k rows ms 696.5 1,061.6 903.8 912.78 122.116
Select 100k rows ms 214.5 402 316.3 295.04 69.966
Deselect 100k rows ms 140.8 302.4 244.8 237.02 52.816

Generated by 🚫 dangerJS against 53b6746

@LukasTy
Copy link
Member Author

LukasTy commented Jun 26, 2023

We are getting errors because ast-types is unaware of the satisfies operator: benjamn/ast-types#935
This blocks us from using satisfies until ast-types updates it on their end, or monorepo bumps react-docgen, which no longer depends on ast-types and hopefully then the mentioned operator would finally be supported on all the chains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module! typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants