Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] OK-ish for production #2356

Merged
merged 1 commit into from
Jul 25, 2023
Merged

[docs] OK-ish for production #2356

merged 1 commit into from
Jul 25, 2023

Conversation

oliviertassinari
Copy link
Member

Since it's in beta, it's fine now?

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Jul 24, 2023
bharatkashyap
bharatkashyap approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@bharatkashyap bharatkashyap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

Janpot
Janpot approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with removing the warning. Not sure whether beta software should be explicitly advertised as "production ready" though.

@oliviertassinari oliviertassinari merged commit b7f150a into mui:master Jul 25, 2023
@oliviertassinari oliviertassinari deleted the fine-for-production branch July 25, 2023 13:02
@oliviertassinari oliviertassinari changed the title [docs] Fine for production [docs] OK-ish for production Jul 25, 2023
@oliviertassinari
Copy link
Member Author

oliviertassinari commented Jul 25, 2023 •
edited
Loading

Not sure whether beta software should be explicitly advertised as "production ready" though.

@Janpot Agree, the goal of this PR is to keep it undefined (vs. don't do it): it can both be OK and no-OK in production, depending on your risk tolerance to API breaking changes and bugs. I think that developers should be able to define this for themselves at this stage, based on, e.g. our version number, npm downloads, examples, etc.

@Janpot
Copy link
Member

Janpot commented Jul 25, 2023

Well said, that was indeed the idea behind my comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prakhargupta1 prakhargupta1 prakhargupta1 approved these changes

@bharatkashyap bharatkashyap bharatkashyap approved these changes

@Janpot Janpot Janpot approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oliviertassinari @Janpot @bharatkashyap @prakhargupta1