-
-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DashboardLayout] Show nested navigation in mini-drawer #4276
Draft
apedroferreira
wants to merge
9
commits into
mui:master
Choose a base branch
from
apedroferreira:refactor-nav-selected-item
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[DashboardLayout] Show nested navigation in mini-drawer #4276
apedroferreira
wants to merge
9
commits into
mui:master
from
apedroferreira:refactor-nav-selected-item
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apedroferreira
changed the title
Use navigation utils for sidebar selected item
[DashboardLayout] Refactor sidebar selected item logic
Oct 18, 2024
github-actions
bot
added
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Oct 18, 2024
apedroferreira
changed the title
[DashboardLayout] Refactor sidebar selected item logic
[DashboardLayout] Show nested navigation in mini-drawer
Oct 28, 2024
oliviertassinari
added
component: DashboardLayout
component: layout
This is the name of the generic UI component, not the React module!
labels
Nov 8, 2024
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: layout
This is the name of the generic UI component, not the React module!
enhancement
This is not a bug, nor a new feature
PR: out-of-date
The pull request has merge conflicts and can't be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially was just trying to refactor sidebar navigation to use the same navigation cache and utilities as the
PageContainer
component.But this required adding nested navigation to the sidebar for consistency with the warnings we show when there are duplicated navigation items, because the navigation links should match in all variants of the sidebar.
TODO:
Inspiration: