Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Link to docs on PRs #4349

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[docs] Link to docs on PRs #4349

wants to merge 1 commit into from
+463 −5

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Nov 1, 2024 •
edited
Loading

Working on #4348, I missed the easy helper comment (access to preview, links, etc.).

Same as mui/base-ui#394

@oliviertassinari oliviertassinari added the scope: docs-infra Specific to the docs-infra product label Nov 1, 2024
@oliviertassinari oliviertassinari changed the title [docs-infra] Add Danger [docs] Link to docs on PRs Nov 1, 2024
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Nov 1, 2024
@mui-bot
Copy link

mui-bot commented Nov 1, 2024

Netlify deploy preview

https://deploy-preview-4349--mui-toolpad-docs.netlify.app/

Generated by 🚫 dangerJS against d744b9e

bharatkashyap
bharatkashyap approved these changes Nov 2, 2024
View reviewed changes
Copy link
Member

@bharatkashyap bharatkashyap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be cool to also be able to identify pages of the docs which have been modified and link to them from the auto-generated comment

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharatkashyap bharatkashyap bharatkashyap approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation PR: out-of-date The pull request has merge conflicts and can't be merged scope: docs-infra Specific to the docs-infra product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oliviertassinari @mui-bot @bharatkashyap