Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Correct version on themed example #4405

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[docs] Correct version on themed example #4405

wants to merge 5 commits into from
+5 −7

Conversation

bharatkashyap
Copy link
Member

@bharatkashyap bharatkashyap commented Nov 11, 2024 •
edited
Loading

@bharatkashyap bharatkashyap added the docs Improvements or additions to the documentation label Nov 11, 2024
@prakhargupta1
Copy link
Member

https://github.com/mui/toolpad/blob/master/examples/core/auth-nextjs-passkey/package.json and https://github.com/mui/toolpad/blob/master/examples/core/auth-vite/package.json have "@toolpad/core": "workspace:*" configuration, but other have 'latest'. IDK if this needs to be fixed.

@bharatkashyap
Copy link
Member Author

https://github.com/mui/toolpad/blob/master/examples/core/auth-nextjs-passkey/package.json and https://github.com/mui/toolpad/blob/master/examples/core/auth-vite/package.json have "@toolpad/core": "workspace:*" configuration, but other have 'latest'. IDK if this needs to be fixed.

Good catch, all of these should be latest. I'll correct this here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prakhargupta1 prakhargupta1 prakhargupta1 approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bharatkashyap @prakhargupta1