Update grammar in BuildInstructions.md #7060
Open
+9
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to improve grammar and spelling in the file
MarkusPettersson98
requested changes
Oct 28, 2024
There was a problem hiding this comment.
Looks pretty good! Left a small nit ⛏️
Also, we can't accept PRs that merge main into them. Please rebase on top of main instead. Drop the last merge commit and run git rebase origin main where origin is the upstream repository [email protected]:mullvad/mullvadvpn-app.git. Thanks!
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Typecosa)
BuildInstructions.md line 144 at r1 (raw file):
./build.sh [--optimize]This should produce an installer exe, pkg, or rpm+deb file in the
dist/directory.
We don't have any rules stating that we should use Oxford commas. Please, revert this change 😊
Code quote:
exe, pkg, or rpm+deb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to improve grammar and spelling in the file
This change is