Prevent install of x86 app on arm64 Windows, and vice versa #7149
Conversation
dlon
force-pushed
the
block-installer-on-arm
branch
from
faf972f
to
7d8b3af
Compare
dlon
changed the title
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @dlon)
dist-assets/windows/installer.nsh line 697 at r1 (raw file):
StrCpy $NativeTarget "x64" ${ElseIf} ${IsNativeARM64} StrCpy $NativeTarget "ARM64"
is this intended to line up with https://www.electron.build/builder-util.typealias.archtype ?
If so, that should be documented. Also, shouldn't it be "arm64" (lower case)?
dlon
force-pushed
the
block-installer-on-arm
branch
from
821c768
to
0c2687c
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @hulthe)
dist-assets/windows/installer.nsh line 697 at r1 (raw file):
Previously, hulthe (Joakim Hulthe) wrote…
is this intended to line up with https://www.electron.build/builder-util.typealias.archtype ?
If so, that should be documented. Also, shouldn't it be "arm64" (lower case)?
Done and done.
dlon
force-pushed
the
block-installer-on-arm
branch
from
8c7c553
to
5e75356
Compare
There was a problem hiding this comment.
lgtm, assuming it's been tested on arm and intel
Reviewed 1 of 2 files at r1, 1 of 1 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
Since there is currently a separate build for ARM Windows.
Close DES-187.
This change is