Use <[T]>::split_at_checked instead of two separate get calls #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplifies the code. Probably allows for more optimized code when compiling without optimizations. For opt-level=3 the result is the same as before
Serock3
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the code primarily. Probably allows for sliiightly more optimized code when compiling without optimizations also (?) For opt-level=3 the result is the same as before.
This split method was stabilized in Rust 1.80, released yesterday. But we don't need to support any old compilers. We are also not aiming for a release of this program/library right away. This is just a cleanup I have been wanting to do for a long time :D
This change is