Add public constant for header size #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hulthe
approved these changes
Oct 21, 2024
dlon
force-pushed
the
add-pub-header-constant
branch
from
c8b80f2
to
c4c839b
Compare
faern
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Mullvad app is forced to assume that the header is 2 bytes long: https://github.com/mullvad/mullvadvpn-app/blob/f72944e5fe88cb954a93da7bd2a868eb75c445ae/tunnel-obfuscation/src/udp2tcp.rs#L94
That's fine, because the protocol will never change, but it would be slightly cleaner to have a constant.
This change is