bulk-payments: Add new contract #146
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a proxy deployer for bulk-payments SC
Coverage SummaryTotals
FilesExpand
|
|
Contract comparison - from d451bc5 to 3a2bbef
|
andreiblt1304
previously approved these changes
Jun 5, 2025
psorinionut
reviewed
Jun 12, 2025
| let user_already_opted_in = self.is_user_opted_in(caller.clone()); | ||
|
|
||
| // If opted in and still getting rewards | ||
| if user_already_opted_in && !self.is_timestamp_expired(caller.clone()) { |
There was a problem hiding this comment.
So you allow users who already opted in, but expired, to opt in again?
There was a problem hiding this comment.
Also, would it be helpful to add a time check for reentering? Or a maximum number of entries per epoch?
| fn addr_timestamp(&self, user: ManagedAddress) -> SingleValueMapper<u64>; | ||
|
|
||
| #[storage_mapper("optedInAddrs")] | ||
| fn opted_in_addrs(&self) -> SetMapper<ManagedAddress<Self::Api>>; |
There was a problem hiding this comment.
Being a queue basically, I would recommend to use LinkedListMapper, which is made mostly for these types of cases. It allows you to better add/remove from the front / back of the list and it is more efficient.
| self.opted_in_addrs().insert(caller); | ||
| } | ||
|
|
||
| fn try_clear_first_user_if_timestamp_expired(&self) { |
There was a problem hiding this comment.
Wouldn't it be more efficient to clear multiple entries that expired? Maybe not all of them (to avoid outOfGas errors), but in batches?
|
|
||
| // Returns user without timestamp expired | ||
| #[view(getUsersOptedIn)] | ||
| fn get_users_opted_in(&self) -> MultiValueEncoded<ManagedAddress> { |
There was a problem hiding this comment.
Not sure if this works or how it works for an array as big as MAX_USERS_ALLOW = 1000.
| } | ||
|
|
||
| #[multiversx_sc::contract] | ||
| pub trait BulkPayments { |
There was a problem hiding this comment.
Is BulkPayments a proper name for this contract. This makes me expect a different type of SC.
|
|
||
| let user_already_opted_in = self.is_user_opted_in(caller.clone()); | ||
|
|
||
| // If opted in and still getting rewards |
There was a problem hiding this comment.
How are the rewards distributed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.